Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trace): UI lazy loading of spans #4014

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Jul 25, 2024

resolves #3917

Makes it so that the span lazily loads only on selection.

@mikeldking mikeldking force-pushed the mikeldking/3917-span-lazy-loading branch from a84e638 to ee74148 Compare July 26, 2024 04:52
@mikeldking mikeldking marked this pull request as ready for review July 26, 2024 04:56
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jul 26, 2024
}, [span]);
const showAnnotations = useFeatureFlag("annotations");
return (
<Flex direction="column" flex="1 1 auto" height="100%">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stuff below here is just copied over from old trace page span details correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@mikeldking mikeldking merged commit ab4fafa into main Jul 26, 2024
6 checks passed
@mikeldking mikeldking deleted the mikeldking/3917-span-lazy-loading branch July 26, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trace lazy loading [ENHANCEMENT]
2 participants